[
https://issues.apache.org/jira/browse/FLINK-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020682#comment-16020682
]
ASF GitHub Bot commented on FLINK-6328:
---------------------------------------
Github user tony810430 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3965#discussion_r117902054
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -864,22 +864,28 @@ private void
completePendingCheckpoint(PendingCheckpoint pendingCheckpoint) thro
// the pending checkpoint must be discarded after the
finalization
Preconditions.checkState(pendingCheckpoint.isDiscarded() && completedCheckpoint
!= null);
- try {
-
completedCheckpointStore.addCheckpoint(completedCheckpoint);
- } catch (Exception exception) {
- // we failed to store the completed checkpoint.
Let's clean up
- executor.execute(new Runnable() {
- @Override
- public void run() {
- try {
-
completedCheckpoint.discardOnFailedStoring();
- } catch (Throwable t) {
- LOG.warn("Could not
properly discard completed checkpoint {}.",
completedCheckpoint.getCheckpointID(), t);
+ // TODO: add savepoints to completed checkpoint store
once FLINK-4815 has been completed
+ if
(!CheckpointProperties.isSavepoint(completedCheckpoint.getProperties())) {
--- End diff --
Why not use `completedCheckpoint.getProperties().isSavepoint()` to check
whether it is a savepoint or not?
This method had already been implemented in `CheckpoinProperties`.
> Savepoints must not be counted as retained checkpoints
> ------------------------------------------------------
>
> Key: FLINK-6328
> URL: https://issues.apache.org/jira/browse/FLINK-6328
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing
> Affects Versions: 1.2.0, 1.3.0, 1.4.0
> Reporter: Stephan Ewen
> Assignee: Till Rohrmann
> Priority: Blocker
> Fix For: 1.3.0, 1.2.2
>
>
> The Checkpoint Store retains the *n* latest checkpoints.
> Savepoints are counted as well, meaning that for settings with 1 retained
> checkpoint, there are sometimes no retained checkpoints at all, only a
> savepoint.
> That is dangerous, because savepoints must be assumed to disappear at any
> point in time - their lifecycle is out of control of the
> CheckpointCoordinator.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
