Github user tony810430 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3965#discussion_r117902054
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -864,22 +864,28 @@ private void
completePendingCheckpoint(PendingCheckpoint pendingCheckpoint) thro
// the pending checkpoint must be discarded after the
finalization
Preconditions.checkState(pendingCheckpoint.isDiscarded() && completedCheckpoint
!= null);
- try {
-
completedCheckpointStore.addCheckpoint(completedCheckpoint);
- } catch (Exception exception) {
- // we failed to store the completed checkpoint.
Let's clean up
- executor.execute(new Runnable() {
- @Override
- public void run() {
- try {
-
completedCheckpoint.discardOnFailedStoring();
- } catch (Throwable t) {
- LOG.warn("Could not
properly discard completed checkpoint {}.",
completedCheckpoint.getCheckpointID(), t);
+ // TODO: add savepoints to completed checkpoint store
once FLINK-4815 has been completed
+ if
(!CheckpointProperties.isSavepoint(completedCheckpoint.getProperties())) {
--- End diff --
Why not use `completedCheckpoint.getProperties().isSavepoint()` to check
whether it is a savepoint or not?
This method had already been implemented in `CheckpoinProperties`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
