[ 
https://issues.apache.org/jira/browse/FLINK-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16028330#comment-16028330
 ] 

ASF GitHub Bot commented on FLINK-6732:
---------------------------------------

Github user dawidwys commented on the issue:

    https://github.com/apache/flink/pull/4009
  
    I've created set of changes that remove ~3k checkstyle violations in 
flink-java. 
    
    I had doubts about changing some `public static final classes` into 
`private static final classes` e.g in `MinAggregationFunction.java`. Is it safe 
to do so? Can I check it does not interfere with any part of the system. Or 
should I just revert it and add appropriate javadoc?
    
    @zentol What is your opinion?


> Activate strict checkstyle for flink-java
> -----------------------------------------
>
>                 Key: FLINK-6732
>                 URL: https://issues.apache.org/jira/browse/FLINK-6732
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Java API
>            Reporter: Chesnay Schepler
>            Assignee: Dawid Wysakowicz
>
> Long term issue for incrementally introducing the strict checkstyle to 
> flink-java.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to