Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4070#discussion_r120081629
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/ProjectionTranslator.scala
---
@@ -226,30 +226,69 @@ object ProjectionTranslator {
overWindows: Array[OverWindow],
tEnv: TableEnvironment): Seq[Expression] = {
- def resolveOverWindow(unresolvedCall: UnresolvedOverCall): Expression
= {
-
- val overWindow =
overWindows.find(_.alias.equals(unresolvedCall.alias))
- if (overWindow.isDefined) {
- OverCall(
- unresolvedCall.agg,
- overWindow.get.partitionBy,
- overWindow.get.orderBy,
- overWindow.get.preceding,
- overWindow.get.following)
- } else {
- unresolvedCall
- }
- }
+ exprs.map(e => replaceOverCall(e, overWindows, tEnv))
+ }
- val projectList = new ListBuffer[Expression]
- exprs.foreach {
- case Alias(u: UnresolvedOverCall, name, _) =>
- projectList += Alias(resolveOverWindow(u), name)
+ /**
+ * Find and replace UnresolvedOverCall with OverCall
+ *
+ * @param expr the expression to check
+ * @return an expression with correct resolved OverCall
+ */
+ private def replaceOverCall(
+ expr: Expression,
+ overWindows: Array[OverWindow],
+ tableEnv: TableEnvironment): Expression = {
+
+ expr match {
case u: UnresolvedOverCall =>
- projectList += resolveOverWindow(u)
- case e: Expression => projectList += e
+ val overWindow = overWindows.find(_.alias.equals(u.alias))
+ if (overWindow.isDefined) {
+ OverCall(
+ u.agg,
+ overWindow.get.partitionBy,
+ overWindow.get.orderBy,
+ overWindow.get.preceding,
+ overWindow.get.following)
+ } else {
+ u
+ }
+
+ case u: UnaryExpression =>
+ val c = replaceOverCall(u.child, overWindows, tableEnv)
+ u.makeCopy(Array(c))
+
+ case b: BinaryExpression =>
+ val l = replaceOverCall(b.left, overWindows, tableEnv)
+ val r = replaceOverCall(b.right, overWindows, tableEnv)
+ b.makeCopy(Array(l, r))
+
+ // Functions calls
+ case c @ Call(name, args: Seq[Expression]) =>
+ val newArgs =
+ args.map(
+ (exp: Expression) =>
+ replaceOverCall(exp, overWindows, tableEnv))
+ c.makeCopy(Array(name, newArgs))
+
+ // Scala functions
+ case sfc @ ScalarFunctionCall(clazz, args: Seq[Expression]) =>
+ val newArgs: Seq[Expression] =
+ args.map(
+ (exp: Expression) =>
+ replaceOverCall(exp, overWindows, tableEnv))
+ sfc.makeCopy(Array(clazz, newArgs))
+
+ // Array constructor
+ case c @ ArrayConstructor(args) =>
--- End diff --
Can you explain me that when we using `ArrayConstructor` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
