[
https://issues.apache.org/jira/browse/FLINK-6901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046837#comment-16046837
]
ASF GitHub Bot commented on FLINK-6901:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4112#discussion_r121480837
--- Diff:
flink-core/src/main/java/org/apache/flink/util/StringValueUtils.java ---
@@ -114,15 +114,17 @@ public boolean next(StringValue target) {
int pos = this.pos;
// skip the delimiter
- for (; pos < limit &&
Character.isWhitespace(data[pos]); pos++);
+ for (; pos < limit &&
Character.isWhitespace(data[pos]); pos++) {
--- End diff --
The `NeedBraces` module was extended with the strict-checkstyle to also
apply to `do`, `while` and `for`.
Since i can't selectively disable parts of the module I had to make the
changes instead.
> Flip checkstyle configuration files
> -----------------------------------
>
> Key: FLINK-6901
> URL: https://issues.apache.org/jira/browse/FLINK-6901
> Project: Flink
> Issue Type: Improvement
> Components: Checkstyle
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
>
> We currently have 2 checkstyle files, {{checkstyle.xml}} as the basic
> version, and {{strict-checkstyle.xml}} as a heavily expanded version that is
> applied to most existing modules (see FLINK-6698).
> [~greghogan] suggested to flip the checkstyle while reviewing this PR
> https://github.com/apache/flink/pull/4086, given that the strict checkstyle
> is supposed to subsume the existing checkstyle in the long-term.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
