[
https://issues.apache.org/jira/browse/FLINK-6921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049311#comment-16049311
]
ASF GitHub Bot commented on FLINK-6921:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4126
[FLINK-6921] [serializer] Allow EnumValueSerializer to deal with appended
enum values
The problem was that we don't check the bounds of the array with the enum
names contained
in the ScalaEnumSerializerConfigSnapshot.
This PR also adds an Enumeration upgrade test which makes sure that
appended fields are
supported without migration. Moreover, it checks that a field removal and
an order change
leads to a required migration.
cc @tzulitai
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink addEnumValueSerializerTest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4126.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4126
----
commit 0f2dcbab59185888137f2d0b278878f3d83c7aa2
Author: Till Rohrmann <trohrm...@apache.org>
Date: 2017-06-14T14:53:49Z
[FLINK-6921] [serializer] Allow EnumValueSerializer to deal with appended
enum values
The problem was that we don't check the bounds of the array with the enum
names contained
in the ScalaEnumSerializerConfigSnapshot.
This PR also adds an Enumeration upgrade test which makes sure that
appended fields are
supported without migration. Moreover, it checks that a field removal and
an order change
leads to a required migration.
----
> EnumValueSerializer cannot properly handle appended enum values
> ---------------------------------------------------------------
>
> Key: FLINK-6921
> URL: https://issues.apache.org/jira/browse/FLINK-6921
> Project: Flink
> Issue Type: Bug
> Components: Type Serialization System
> Affects Versions: 1.3.1, 1.4.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
>
> The {{EnumValueSerializer}} fails with an {{ArrayIndexOutOfBoundsException}}
> if we try to ensure compatibility with an {{Enumeration}} which has added a
> field. The problem is that we don't check the array bounds of the array
> containing the enum names in {{ScalaEnumSerializerConfigSnapshot}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
