Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/729#discussion_r31532320
  
    --- Diff: 
flink-java/src/main/java/org/apache/flink/api/java/sca/UdfAnalyzer.java ---
    @@ -0,0 +1,431 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.api.java.sca;
    +
    +import org.apache.flink.api.common.functions.CoGroupFunction;
    +import org.apache.flink.api.common.functions.CrossFunction;
    +import org.apache.flink.api.common.functions.FilterFunction;
    +import org.apache.flink.api.common.functions.FlatJoinFunction;
    +import org.apache.flink.api.common.functions.FlatMapFunction;
    +import org.apache.flink.api.common.functions.GroupReduceFunction;
    +import org.apache.flink.api.common.functions.JoinFunction;
    +import org.apache.flink.api.common.functions.MapFunction;
    +import org.apache.flink.api.common.functions.ReduceFunction;
    +import org.apache.flink.api.common.operators.DualInputSemanticProperties;
    +import org.apache.flink.api.common.operators.SemanticProperties;
    +import org.apache.flink.api.common.operators.SingleInputSemanticProperties;
    +import org.apache.flink.api.common.typeinfo.TypeInformation;
    +import org.apache.flink.api.java.functions.SemanticPropUtil;
    +import org.apache.flink.api.java.operators.Keys;
    +import org.apache.flink.api.java.operators.Keys.ExpressionKeys;
    +import org.apache.flink.api.java.sca.TaggedValue.Input;
    +import org.objectweb.asm.Type;
    +import org.objectweb.asm.tree.MethodNode;
    +
    +import java.lang.reflect.Method;
    +import java.util.ArrayList;
    +import java.util.List;
    +
    +import static 
org.apache.flink.api.java.sca.UdfAnalyzerUtils.convertTypeInfoToTaggedValue;
    +import static 
org.apache.flink.api.java.sca.UdfAnalyzerUtils.findMethodNode;
    +import static 
org.apache.flink.api.java.sca.UdfAnalyzerUtils.mergeReturnValues;
    +import static 
org.apache.flink.api.java.sca.UdfAnalyzerUtils.removeUngroupedInputsFromContainer;
    +
    +public class UdfAnalyzer {
    +   // exclusion to suppress hints for API operators
    +   private static final String EXCLUDED_CLASSPATH = "org/apache/flink";
    --- End diff --
    
    Instead of excluding this class path, the consensus from reviews so far is 
to add an `@SkipCodeAnalysis` annotation. This will allow new users to play 
around with the Flink examples etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to