[ https://issues.apache.org/jira/browse/FLINK-1981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14569601#comment-14569601 ]
ASF GitHub Bot commented on FLINK-1981: --------------------------------------- Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/762#discussion_r31560285 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/FileInputFormat.java --- @@ -628,9 +692,10 @@ public void open(FileInputSplit fileSplit) throws IOException { * @see org.apache.flink.api.common.io.InputStreamFSInputWrapper */ protected FSDataInputStream decorateInputStream(FSDataInputStream inputStream, FileInputSplit fileSplit) throws Throwable { - // Wrap stream in a extracting (decompressing) stream if file ends with .deflate. - if (fileSplit.getPath().getName().endsWith(DEFLATE_SUFFIX)) { - return new InflaterInputStreamFSInputWrapper(stream); + // Wrap stream in a extracting (decompressing) stream if file ends with a known compression file extension. + InflaterInputStreamFactory<?> inflaterInputStreamFactory = getInflaterInputStreamFactory(fileSplit.getPath()); + if (inflaterInputStreamFactory != null) { + return new InputStreamFSInputWrapper(inflaterInputStreamFactory.create(stream)); --- End diff -- so if there is no inflater input stream available, it will just fall back to the compressed data stream? Wouldn't it better to at least log something or fail? > Add GZip support > ---------------- > > Key: FLINK-1981 > URL: https://issues.apache.org/jira/browse/FLINK-1981 > Project: Flink > Issue Type: New Feature > Components: Core > Reporter: Sebastian Kruse > Assignee: Sebastian Kruse > Priority: Minor > > GZip, as a commonly used compression format, should be supported in the same > way as the already supported deflate files. This allows to use GZip files > with any subclass of FileInputFormat. -- This message was sent by Atlassian JIRA (v6.3.4#6332)