[
https://issues.apache.org/jira/browse/FLINK-6457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057575#comment-16057575
]
ASF GitHub Bot commented on FLINK-6457:
---------------------------------------
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3880
Hi @Xpray, I left a comment on the related JIRA issue. In short, I do not
why we should remove methods with constant signature and call them via
reflection. This makes the code more prone for failures, it is less comfortable
for users that need to override the methods and does not change anything for
users that do not need these methods.
It would be great if you could reply on the JIRA.
Thank you, Fabian
> Clean up ScalarFunction and TableFunction interface
> ---------------------------------------------------
>
> Key: FLINK-6457
> URL: https://issues.apache.org/jira/browse/FLINK-6457
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Ruidong Li
> Assignee: Ruidong Li
>
> Motivation:
> Some methods in ScalarFunction and TableFunction are unnecessary, e.g
> toString() and getResultType in ScalarFunction
> this issue intend to clear the interface.
> Goal:
> only methods related to `Collector` will remain in TableFunction interface,
> and ScalarFunction interface shall have no methods , user can choose whether
> to implement the `getResultType` method, which will be called by reflection,
> and the Flink document will have instructions for user.
> Future:
> There should be some Annotations for user to implement methods like `@Eval`
> for eval method, it be will in the next issue
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
