[
https://issues.apache.org/jira/browse/FLINK-7014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065798#comment-16065798
]
ASF GitHub Bot commented on FLINK-7014:
---------------------------------------
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4200#discussion_r124436213
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/datastream/DataStreamUserDefinedFunctionITCase.scala
---
@@ -230,6 +231,26 @@ class DataStreamUserDefinedFunctionITCase extends
StreamingMultipleProgramsTestB
assertEquals(expected.sorted, StreamITCase.testResults.sorted)
}
+
+ @Test
+ def testScalarFunctionDeterministic(): Unit = {
--- End diff --
I think an IT case can't cover this change. Whether the UDF is
deterministic or not, the result should be same.
> Expose isDeterministic interface to ScalarFunction and TableFunction
> --------------------------------------------------------------------
>
> Key: FLINK-7014
> URL: https://issues.apache.org/jira/browse/FLINK-7014
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Ruidong Li
> Assignee: Ruidong Li
>
> Currently, the `isDeterministic` method of implementations of `SqlFuntion`
> are always returning true, which cause inappropriate optimization in Calcite,
> such as taking user's stateful UDF as a pure functional procedure.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
