[ 
https://issues.apache.org/jira/browse/FLINK-7017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066016#comment-16066016
 ] 

ASF GitHub Bot commented on FLINK-7017:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4196#discussion_r124464897
  
    --- Diff: 
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/WebFrontendITCase.java
 ---
    @@ -83,16 +78,16 @@ public static void initialize() throws Exception {
                assertTrue("Unable to create temp directory", logDir.mkdir());
                File logFile = new File(logDir, "jobmanager.log");
                File outFile = new File(logDir, "jobmanager.out");
    -           
    +
                Files.createFile(logFile.toPath());
                Files.createFile(outFile.toPath());
    -           
    +
                config.setString(JobManagerOptions.WEB_LOG_PATH, 
logFile.getAbsolutePath());
                config.setString(ConfigConstants.TASK_MANAGER_LOG_PATH_KEY, 
logFile.getAbsolutePath());
     
                cluster = new LocalFlinkMiniCluster(config, false);
                cluster.start();
    -           
    +
    --- End diff --
    
    this is the removal of leading tabs that is required by the checkstyle 
active in `flink-runtime-web`.


> Remove netty usages in flink-tests
> ----------------------------------
>
>                 Key: FLINK-7017
>                 URL: https://issues.apache.org/jira/browse/FLINK-7017
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to