Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4195#discussion_r124501193
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/ComputationState.java
---
@@ -114,6 +115,28 @@ public DeweyNumber getVersion() {
return version;
}
+ @Override
+ public boolean equals(Object obj) {
+ if (obj instanceof ComputationState) {
+ ComputationState other = (ComputationState) obj;
+ return Objects.equals(state, other.state) &&
+ event == other.event &&
--- End diff --
The combination of `Object.equals(event, other.event)` and `count ==
other.counter` tells exactly that. I would not base the implementation on
reference equity.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
