Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4170#discussion_r124547670
--- Diff:
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/Runner.java
---
@@ -305,6 +334,41 @@ public static void main(String[] args) throws
Exception {
default:
throw new
ProgramParametrizationException("Unknown output type: " + outputName);
}
+
+ //
----------------------------------------------------------------------------------------
+ // Write job details
--- End diff --
It would nicer to extract this if condition to `writeJobDetails` method and
delete this comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---