[ https://issues.apache.org/jira/browse/FLINK-7070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073344#comment-16073344 ]
ASF GitHub Bot commented on FLINK-7070: --------------------------------------- Github user zentol commented on the issue: https://github.com/apache/flink/pull/4249 +1. > Rework ScalaShellITCase#testSubmissionOfExternalLibraryStream > ------------------------------------------------------------- > > Key: FLINK-7070 > URL: https://issues.apache.org/jira/browse/FLINK-7070 > Project: Flink > Issue Type: Improvement > Components: Scala Shell, Tests > Affects Versions: 1.4.0 > Reporter: Chesnay Schepler > Priority: Critical > Fix For: 1.4.0 > > > The {{ScalaShellITCase}} makes use of flink-ml jar in one of it's tests. > Since flink-ml is not even declared as a dependency the test only works > because by coincidence flink-ml is build before flink-scala-shell. > {code} > @Test > def testSubmissionOfExternalLibraryBatch: Unit = { > ... > val folder = findLibraryFolder( > "../flink-libraries/flink-ml/target/", > "../../flink-libraries/flink-ml/target/") > ... > } > def findLibraryFolder(paths: String*): File = { > for (path <- paths) { > val folder = new File(path) > if (folder.exists()) { > return folder > } > } > throw new RuntimeException("Library folder not found in any of the > supplied paths!") > } > {code} > At the very least we should declare the dependency, or even better rework > this test to rely on a custom jar built in flink-scala-shell to reduce > dependencies. > Also, the exception message in {{findLibraryFolder}} should contain the > folder it couldn't find. -- This message was sent by Atlassian JIRA (v6.4.14#64029)