Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4157#discussion_r125423153
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/queryConfig.scala
 ---
    @@ -37,6 +37,13 @@ class BatchQueryConfig private[table] extends QueryConfig
     class StreamQueryConfig private[table] extends QueryConfig {
     
       /**
    +    * The non-windowed groupby aggregate update the calculation result 
according a configuration of
    +    * time interval. By default non-windowed groupby aggregate will update 
calculation result each
    +    * row.
    +    */
    +  private var unboundedAggregateUpdateInterval: Time = Time.milliseconds(0)
    --- End diff --
    
    I think `updateRate` meant update result in a fixed frequency, so we should 
register a process-time timer. i.e., System clock driven the trigger.  And 
`updateInterval` meant update result according coming data. so I we should 
register a event-time timer. i.e, Data driven the trigger.
    I think it again, I suggest using `updateInterval`, i.e., we emit result 
according event-time of data.
    What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to