Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/729#discussion_r31711766
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/functions/SemanticPropUtil.java
---
@@ -309,15 +308,20 @@ public static DualInputSemanticProperties
getSemanticPropsDual(
getSemanticPropsDualFromString(result, forwardedFirst,
forwardedSecond,
nonForwardedFirst, nonForwardedSecond,
readFirst, readSecond, inType1, inType2, outType);
return result;
- } else {
- return new DualInputSemanticProperties();
}
+ return null;
+ }
+
+ public static void
getSemanticPropsSingleFromString(SingleInputSemanticProperties result,
+
String[] forwarded, String[] nonForwarded,
String[] readSet,
+
TypeInformation<?> inType, TypeInformation<?>
outType) {
+ getSemanticPropsSingleFromString(result, forwarded,
nonForwarded, readSet, inType, outType, false);
}
public static void
getSemanticPropsSingleFromString(SingleInputSemanticProperties result,
String[] forwarded, String[] nonForwarded, String[]
readSet,
- TypeInformation<?> inType, TypeInformation<?> outType)
- {
+ TypeInformation<?> inType, TypeInformation<?> outType,
+ boolean skipIncompatibleTypes) {
--- End diff --
Can you explain a bit, why you introduced this flag?
Why should is be possible to skip the compatibility checks?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
