[ 
https://issues.apache.org/jira/browse/FLINK-7109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16076655#comment-16076655
 ] 

ASF GitHub Bot commented on FLINK-7109:
---------------------------------------

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/4265
  
    Failing test is unrelated. Merging this PR.


> HadoopUtils#getHadoopConfiguration should not load global configuration
> -----------------------------------------------------------------------
>
>                 Key: FLINK-7109
>                 URL: https://issues.apache.org/jira/browse/FLINK-7109
>             Project: Flink
>          Issue Type: Improvement
>          Components: Configuration
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>             Fix For: 1.4.0
>
>
> The {{HadoopUtils#getHadoopConfiguration}} should not load the global 
> configuration via {{GlobalConfiguration.loadConfiguration}}. Instead we 
> should pass a valid Flink configuration to the static method. Otherwise, we 
> will load the global configuration whenever 
> {{HadoopUtils#getHadoopConfiguration}} is called.
> Usually {{HadoopUtils#getHadoopConfiguration}} is only used by 
> {{HadoopInputFormatBase}}, for example. However with the addition of the 
> {{SecurityConfiguration}}, also this class loads the Hadoop configuration.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to