Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4110#discussion_r126940120
--- Diff:
flink-metrics/flink-metrics-statsd/src/test/java/org/apache/flink/metrics/statsd/StatsDReporterTest.java
---
@@ -60,6 +60,20 @@
public class StatsDReporterTest extends TestLogger {
@Test
+ public void testNameTruncating() {
+ StatsDReporter reporter = new StatsDReporter();
+
+ MetricConfig config = new MetricConfig();
+ config.setProperty(StatsDReporter.ARG_HOST, "localhost");
+ config.setProperty(StatsDReporter.ARG_PORT, "12345");
+ config.setProperty(StatsDReporter.ARG_MAX_COMPONENT_LENGTH,
"10");
+
+ reporter.open(config);
+
+ assertEquals("0123456789",
reporter.filterCharacters("0123456789DEADBEEF"));
--- End diff --
hmm, seems something was lost during the transfer :(
iirc, I wanted to ask whether it makes sense to also test that things like
`a.b.0123456789DEADBEEF.c` are properly truncated to `a.b.0123456789.c` for the
whole metric name
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
