[ 
https://issues.apache.org/jira/browse/FLINK-7176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086965#comment-16086965
 ] 

ASF GitHub Bot commented on FLINK-7176:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/4330

    [FLINK-7176] [travis] Improve error handling

    1.4 version of #4329.
    
    Additional changes:
    - tests are only executed if the compilation was successful
    - yarn tests log upload is only done in group that actually runs 
flink-yarn-tests

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 7176

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4330.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4330
    
----
commit 8622d116eeb18ff38a2247f6e916a515dd81bbac
Author: zentol <ches...@apache.org>
Date:   2017-07-13T15:53:40Z

    [FLINK-7176] [travis] Improve error handling

----


> Failed builds (due to compilation) don't upload logs
> ----------------------------------------------------
>
>                 Key: FLINK-7176
>                 URL: https://issues.apache.org/jira/browse/FLINK-7176
>             Project: Flink
>          Issue Type: Bug
>          Components: Travis
>    Affects Versions: 1.3.0, 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.3.0, 1.4.0
>
>
> If the compile phase fails on travis {{flink-dist}} may not be created. This 
> causes the check for the inclusion of snappy in {{flink-dist}} to fail.
> The function doing this check calls {{exit 1}} on error, which exits the 
> entire shell, thus skipping subsequent actions like the upload of logs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to