[
https://issues.apache.org/jira/browse/FLINK-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091611#comment-16091611
]
ASF GitHub Bot commented on FLINK-5541:
---------------------------------------
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4315
checkstyle violation: [ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (validate) on
project flink-storm_2.11: You have 1 Checkstyle violation. -> [Help 1]
> Missing null check for localJar in FlinkSubmitter#submitTopology()
> ------------------------------------------------------------------
>
> Key: FLINK-5541
> URL: https://issues.apache.org/jira/browse/FLINK-5541
> Project: Flink
> Issue Type: Bug
> Components: Storm Compatibility
> Reporter: Ted Yu
> Assignee: mingleizhang
> Priority: Minor
>
> {code}
> if (localJar == null) {
> try {
> for (final URL url : ((ContextEnvironment)
> ExecutionEnvironment.getExecutionEnvironment())
> .getJars()) {
> // TODO verify that there is only one jar
> localJar = new File(url.toURI()).getAbsolutePath();
> }
> } catch (final URISyntaxException e) {
> // ignore
> } catch (final ClassCastException e) {
> // ignore
> }
> }
> logger.info("Submitting topology " + name + " in distributed mode with
> conf " + serConf);
> client.submitTopologyWithOpts(name, localJar, topology);
> {code}
> Since the try block may encounter URISyntaxException / ClassCastException, we
> should check that localJar is not null before calling
> submitTopologyWithOpts().
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
