[ 
https://issues.apache.org/jira/browse/FLINK-7234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093710#comment-16093710
 ] 

ASF GitHub Bot commented on FLINK-7234:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4372#discussion_r128351347
  
    --- Diff: docs/dev/batch/index.md ---
    @@ -205,20 +205,25 @@ data.filter(new FilterFunction<Integer>() {
           <td><strong>Reduce</strong></td>
           <td>
             <p>Combines a group of elements into a single element by 
repeatedly combining two elements
    -        into one. Reduce may be applied on a full data set, or on a 
grouped data set.</p>
    +        into one. Reduce may be applied on a full data set or on a grouped 
data set.</p>
     {% highlight java %}
     data.reduce(new ReduceFunction<Integer> {
       public Integer reduce(Integer a, Integer b) { return a + b; }
     });
     {% endhighlight %}
    +        <p>If the reduce was applied to a grouped data set then you can 
specify the way that the
    --- End diff --
    
    `If the reduce was ...` -> `If the reduce transformation was ...` or `If 
the reduce function was ...`?


> Fix CombineHint documentation
> -----------------------------
>
>                 Key: FLINK-7234
>                 URL: https://issues.apache.org/jira/browse/FLINK-7234
>             Project: Flink
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 1.2.2, 1.4.0, 1.3.2
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>
> The {{CombineHint}} 
> [documentation|https://ci.apache.org/projects/flink/flink-docs-release-1.4/dev/batch/index.html]
>  applies to {{DataSet#reduce}} not {{DataSet#reduceGroup}} and should also be 
> note for {{DataSet#distinct}}. It is also set with 
> {{.setCombineHint(CombineHint)}} rather than alongside the UDF parameter.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to