[ https://issues.apache.org/jira/browse/FLINK-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093739#comment-16093739 ]
ASF GitHub Bot commented on FLINK-6281: --------------------------------------- Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3712#discussion_r128220251 --- Diff: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormat.java --- @@ -218,10 +225,7 @@ public void writeRecord(Row row) throws IOException { @Override public void close() throws IOException { try { - if (upload != null) { - upload.executeBatch(); - upload.close(); --- End diff -- we should `close()` the `PreparedStatement` > Create TableSink for JDBC > ------------------------- > > Key: FLINK-6281 > URL: https://issues.apache.org/jira/browse/FLINK-6281 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL > Reporter: Haohui Mai > Assignee: Haohui Mai > > It would be nice to integrate the table APIs with the JDBC connectors so that > the rows in the tables can be directly pushed into JDBC. -- This message was sent by Atlassian JIRA (v6.4.14#64029)