Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4364#discussion_r128477515
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphRestartTest.java
 ---
    @@ -727,4 +837,46 @@ private static void haltExecution(ExecutionGraph eg) {
     
                assertEquals(JobStatus.FINISHED, eg.getState());
        }
    +
    +   // 
------------------------------------------------------------------------
    +
    +   /**
    +    * A TaskManager gateway that does not ack cancellations.
    +    */
    +   private static final class NotCancelAckingTaskGateway extends 
SimpleAckingTaskManagerGateway {
    +
    +           @Override
    +           public org.apache.flink.runtime.concurrent.Future<Acknowledge> 
cancelTask(ExecutionAttemptID executionAttemptID, Time timeout) {
    +                   return new FlinkCompletableFuture<>();
    +           }
    +   }
    +
    +   private static final class TriggeredRestartStrategy implements 
RestartStrategy {
    --- End diff --
    
    "A {@link RestartStrategy} that blocks restarting on a given {@link 
OneShotLatch}."?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to