Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r128500452
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -1399,14 +1463,28 @@ object AggregateUtil {
}
}
+ val accSpecs = new Array[Seq[DataViewSpec[_]]](aggregateCalls.size)
+
// create accumulator type information for every aggregate function
aggregates.zipWithIndex.foreach { case (agg, index) =>
- if (null == accTypes(index)) {
+ if (accTypes(index) != null) {
+ val dataViewTypes = getDataViewTypeInfoFromConstructor(agg)
+ val (accType, specs) = extractDataViewTypeInfo(index, agg,
accTypes(index), dataViewTypes,
--- End diff --
break the parameters into multi line
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
