Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/4360
  
    Looks good, +1 with request for minor change:
    
    I would pull out the setting of the merge operator from the option 
factories. We should not allow users to override (or forget to set it), because 
we make a hard assumption on the fact that exactly that merge operator is 
configured.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to