[ 
https://issues.apache.org/jira/browse/FLINK-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110555#comment-16110555
 ] 

ASF GitHub Bot commented on FLINK-7293:
---------------------------------------

Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4418#discussion_r130818022
  
    --- Diff: 
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/operator/CEPOperatorTest.java
 ---
    @@ -923,6 +934,126 @@ public boolean filter(Event value) throws Exception {
                }
        }
     
    +   @Test
    +   public void testCEPOperatorComparatorProcessTime() throws Exception {
    +           Event startEvent1 = new Event(42, "start", 1.0);
    +           Event startEvent2 = new Event(42, "start", 2.0);
    +           SubEvent middleEvent1 = new SubEvent(42, "foo1", 3.0, 10.0);
    +           SubEvent middleEvent2 = new SubEvent(42, "foo2", 4.0, 10.0);
    +           Event endEvent1 = new Event(42, "end", 1.0);
    +
    +           Event startEventK2 = new Event(43, "start", 1.0);
    +
    +           KeyedCEPPatternOperator<Event, Integer> operator = 
getKeyedCepOpearatorWithComparator(true);
    +           OneInputStreamOperatorTestHarness<Event, Map<String, 
List<Event>>> harness = getCepTestHarness(operator);
    +
    +           try {
    +                   harness.open();
    +
    +                   harness.setProcessingTime(0L);
    +
    +                   harness.processElement(new StreamRecord<>(startEvent1, 
1L));
    --- End diff --
    
    Could you update the timestamps to the `0L`(the corresponding processing 
time)? I know it does not matter in `ProcessingTime`, but I think it will be 
easier to read that way. What do you think?


> Support custom order by in PatternStream
> ----------------------------------------
>
>                 Key: FLINK-7293
>                 URL: https://issues.apache.org/jira/browse/FLINK-7293
>             Project: Flink
>          Issue Type: Sub-task
>          Components: CEP
>            Reporter: Dian Fu
>            Assignee: Dian Fu
>
> Currently, when {{ProcessingTime}} is configured, the events are fed to NFA 
> in the order of the arriving time and when {{EventTime}} is configured, the 
> events are fed to NFA in the order of the event time. It should also allow 
> custom {{order by}} to allow users to define the order of the events besides 
> the above factors.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to