[
https://issues.apache.org/jira/browse/FLINK-7356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111543#comment-16111543
]
ASF GitHub Bot commented on FLINK-7356:
---------------------------------------
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/4466
[FLINK-7356][configuration] misleading s3 file uri in configuration file
**(The sections below can be removed for hotfixes of typos)**
## What is the purpose of the change
*Correct the misleading example of s3 file uri in flink-conf.yaml file*
in
https://github.com/apache/flink/blob/master/flink-dist/src/main/resources/flink-conf.yaml,
the comment in line 121 should say `"**s3**://" for S3 file system` rather
than `"**S3**://" for S3 file system`, because `S3://xxx` is not recognized by
AWS SDK.
## Brief change log
- Corrected the comment, and added extra text for alerting
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bowenli86/flink FLINK-7356
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4466.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4466
----
commit 63c74153ede1663b009bb3f3a51d710460524c71
Author: Bowen Li <bowenl...@gmail.com>
Date: 2017-08-02T19:01:36Z
FLINK-7356 misleading s3 file uri in configuration file
----
> misleading s3 file uri in configuration file
> --------------------------------------------
>
> Key: FLINK-7356
> URL: https://issues.apache.org/jira/browse/FLINK-7356
> Project: Flink
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 1.3.1
> Reporter: Bowen Li
> Assignee: Bowen Li
> Fix For: 1.4.0, 1.3.2
>
>
> in
> https://github.com/apache/flink/blob/master/flink-dist/src/main/resources/flink-conf.yaml,
> the comment in line 121 should say {{"*s3*://" for S3 file system}} rather
> than {{"S3://" for S3 file system}}, because {{S3://xxx}} is not recognized
> by AWS SDK.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
