Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4373#discussion_r131094518
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/JoinTest.scala
---
@@ -55,12 +55,13 @@ class JoinTest extends TableTestBase {
unaryNode(
"DataStreamCalc",
streamTableNode(1),
- term("select", "a", "b", "proctime")
+ term("select", "a", "b", "-(proctime, 3600000) AS -",
--- End diff --
Yes, you're of course right @twalthr. This is a valid rewrite and I agree
with you're analysis. We have to prevent the push-down of predicates that
include time indicator fields. The `DataStreamWindowJoin` needs the offsets to
compute the correct window boundaries.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
