[ 
https://issues.apache.org/jira/browse/FLINK-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116670#comment-16116670
 ] 

ASF GitHub Bot commented on FLINK-7316:
---------------------------------------

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4481#discussion_r131672655
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPool.java
 ---
    @@ -274,7 +260,7 @@ private void redistributeBuffers() throws IOException {
                        return;
                }
     
    -           /**
    --- End diff --
    
    Actually, this was intentional since this was marked as a "dangling 
javadoc" by IntelliJ (it is just a longer inline-comment). I don't have too 
strong feelings about it though so we could either keep it or revert it.


> always use off-heap network buffers
> -----------------------------------
>
>                 Key: FLINK-7316
>                 URL: https://issues.apache.org/jira/browse/FLINK-7316
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Core, Network
>    Affects Versions: 1.4.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>
> In order to send flink buffers through netty into the network, we need to 
> make the buffers use off-heap memory. Otherwise, there will be a hidden copy 
> happening in the NIO stack.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to