[ https://issues.apache.org/jira/browse/FLINK-7396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121357#comment-16121357 ]
ASF GitHub Bot commented on FLINK-7396: --------------------------------------- GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4511 [FLINK-7396] Don't put multiple directories in HADOOP_CONF_DIR in config.sh ## What is the purpose of the change Fix put multiple directories in HADOOP_CONF_DIR in config.sh ## Brief change log *(for example:)* - *Check whether HADOOP_CONF_DIR before put directory to it* ## Verifying this change *(Please pick either of the following options)* No test case ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjureel/flink FLINK-7396 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4511.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4511 ---- commit 4d25ba8abad862a5cd04812311043de7f83cac89 Author: zjureel <zjur...@gmail.com> Date: 2017-08-10T08:52:43Z [FLINK-7396] Fix don't put multiple directories in HADOOP_CONF_DIR in config.sh ---- > Don't put multiple directories in HADOOP_CONF_DIR in config.sh > -------------------------------------------------------------- > > Key: FLINK-7396 > URL: https://issues.apache.org/jira/browse/FLINK-7396 > Project: Flink > Issue Type: Bug > Components: Startup Shell Scripts > Affects Versions: 1.4.0, 1.3.2 > Reporter: Aljoscha Krettek > Priority: Blocker > Fix For: 1.4.0, 1.3.3 > > > In config.sh we do this: > {code} > # Check if deprecated HADOOP_HOME is set. > if [ -n "$HADOOP_HOME" ]; then > # HADOOP_HOME is set. Check if its a Hadoop 1.x or 2.x HADOOP_HOME path > if [ -d "$HADOOP_HOME/conf" ]; then > # its a Hadoop 1.x > HADOOP_CONF_DIR="$HADOOP_CONF_DIR:$HADOOP_HOME/conf" > fi > if [ -d "$HADOOP_HOME/etc/hadoop" ]; then > # Its Hadoop 2.2+ > HADOOP_CONF_DIR="$HADOOP_CONF_DIR:$HADOOP_HOME/etc/hadoop" > fi > fi > {code} > while our {{HadoopFileSystem}} actually only treats this paths as a single > path, not a colon-separated path: > https://github.com/apache/flink/blob/854b05376a459a6197e41e141bb28a9befe481ad/flink-runtime/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopFileSystem.java#L236 > I also think that other tools don't assume multiple paths in there and at > least one user ran into the problem on their setup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)