[ 
https://issues.apache.org/jira/browse/FLINK-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121477#comment-16121477
 ] 

ASF GitHub Bot commented on FLINK-7408:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4512#discussion_r132426175
  
    --- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/FlinkMiniCluster.scala
 ---
    @@ -388,7 +388,7 @@ abstract class FlinkMiniCluster(
         : Option[WebMonitor] = {
         if(
           config.getBoolean(ConfigConstants.LOCAL_START_WEBSERVER, false) &&
    -        config.getInteger(JobManagerOptions.WEB_PORT.key(), 0) >= 0) {
    +        config.getInteger(WebOptions.PORT.key(), 0) >= 0) {
    --- End diff --
    
    you can drop the call to `key()`.


> Extract WebRuntimeMonitor options from JobManagerOptions
> --------------------------------------------------------
>
>                 Key: FLINK-7408
>                 URL: https://issues.apache.org/jira/browse/FLINK-7408
>             Project: Flink
>          Issue Type: Improvement
>          Components: Configuration
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Trivial
>
> With the Flip-6 code changes, the {{WebRuntimeMonitor}} won't run exclusively 
> next to the {{JobManager}}. Therefore, it makes sense to refactor the web 
> monitor options and moving them from {{JobManagerOptions}} to {{WebOptions}} 
> and removing the prefix {{jobmanager}}. 
> This is done as requested by 
> https://github.com/apache/flink/pull/4492#issuecomment-321271819.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to