[
https://issues.apache.org/jira/browse/FLINK-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121549#comment-16121549
]
ASF GitHub Bot commented on FLINK-6938:
---------------------------------------
GitHub user dianfu opened a pull request:
https://github.com/apache/flink/pull/4513
[FLINK-6938][FLINK-6939] [cep] Not store IterativeCondition with NFA state
and support RichFunction interface
## What is the purpose of the change
*The core idea is that the StateTransition is unique in a NFA graph. So we
store the conditions with a map which mapping from StateTransition to
IterativeCondition, so the conditions can not serialized with NFA state. If I
missed something, please point out.
This PR also includes FLINK-6938: IterativeCondition supports RichFunction
interface.*
## Verifying this change
This change is already covered by existing tests*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): ( no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (JavaDocs)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dianfu/flink IterativeCondition
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4513.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4513
----
commit e8f4bfd55eb50b151b8160c7c8f8901114aa7606
Author: Jark Wu <[email protected]>
Date: 2017-06-20T06:02:21Z
[FLINK-6938][FLINK-6939] [cep] Not store IterativeCondition with NFA state
and support RichFunction interface
commit 994bc06c11bffbf129d7160a4db2a16db01199d8
Author: Jark Wu <[email protected]>
Date: 2017-06-20T13:25:59Z
minor change
commit ae26dab180943f9b6609341d7447718f772b8b19
Author: Jark Wu <[email protected]>
Date: 2017-06-22T03:17:47Z
address dawid's comments
commit e8c28049d2eb96500f53d6e7f284ae074280b5a1
Author: Dian Fu <[email protected]>
Date: 2017-08-10T12:25:50Z
Rebase the code
----
> IterativeCondition should support RichFunction interface
> --------------------------------------------------------
>
> Key: FLINK-6938
> URL: https://issues.apache.org/jira/browse/FLINK-6938
> Project: Flink
> Issue Type: Sub-task
> Components: CEP
> Reporter: Jark Wu
> Assignee: Jark Wu
> Fix For: 1.4.0
>
>
> In FLIP-20, we need IterativeCondition to support an {{open()}} method to
> compile the generated code once. We do not want to insert a if condition in
> the {{filter()}} method. So I suggest make IterativeCondition support
> {{RichFunction}} interface.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
