GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4518
[FLINK-7412][network] optimise NettyMessage.TaskEventRequest#readFrom() to read from netty buffers directly ## What is the purpose of the change `NettyMessage.TaskEventRequest#readFrom()` had an outstanding TODO to read from the netty buffer directly, instead of copying to a `ByteBuffer` first and then deserializing the event. ## Brief change log - use `ByteBuf#nioBuffer()` to deserialize from a `ByteBuffer` instance wrapping netty's buffer contents ## Verifying this change This change is already covered by existing tests, such as `NettyMessageSerializationTest` as well as many other tests, especially IT cases, involving network. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (yes) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes, if you consider network communication part of this) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) You can merge this pull request into a Git repository by running: $ git pull https://github.com/NicoK/flink flink-7412 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4518.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4518 ---- commit b33e036b43d00ddf564f105280894f6287dd3e92 Author: Nico Kruber <n...@data-artisans.com> Date: 2017-08-07T15:38:36Z [FLINK-7411][network] minor (performance) improvements in NettyMessage * use a switch rather than multiple if conditions * use static `readFrom` methods to create instances of the message sub types commit bce73af1b01793574d748e6536052ec6530360b0 Author: Nico Kruber <n...@data-artisans.com> Date: 2017-08-07T16:12:28Z [FLINK-7412][network] optimise NettyMessage.TaskEventRequest#readFrom() to read from netty buffers directly ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---