[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123282#comment-16123282 ]
ASF GitHub Bot commented on FLINK-7378: --------------------------------------- Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4485#discussion_r132655177 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/FixedBufferPool.java --- @@ -0,0 +1,280 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.io.network.buffer; + +import org.apache.flink.core.memory.MemorySegment; +import org.apache.flink.runtime.util.event.EventListener; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.util.ArrayDeque; +import java.util.Queue; + +import static org.apache.flink.util.Preconditions.checkArgument; +import static org.apache.flink.util.Preconditions.checkNotNull; +import static org.apache.flink.util.Preconditions.checkState; + +/** + * A buffer pool used to manage a number of {@link Buffer} instances from the + * {@link NetworkBufferPool}. + * + * <p> Compared with {@link LocalBufferPool}, this is a fixed size (non-rebalancing) buffer pool --- End diff -- As per our checkstyle (not enforced here yet), you should remove the space after the `<p>`. There are some more places in this PR but I'll stop marking them. > Implement the FixedBufferPool for floating buffers of SingleInputGate > --------------------------------------------------------------------- > > Key: FLINK-7378 > URL: https://issues.apache.org/jira/browse/FLINK-7378 > Project: Flink > Issue Type: Sub-task > Components: Core > Reporter: zhijiang > Assignee: zhijiang > Fix For: 1.4.0 > > > Currently the number of network buffers in {{LocalBufferPool}} for > {{SingleInputGate}} is limited by {{a * <number of channels> + b}}, where a > is the number of exclusive buffers for each channel and b is the number of > floating buffers shared by all channels. > Considering the credit-based flow control feature, we want to implement a new > fixed size buffer pool type used to manage the floating buffers for > {{SingleInputGate}}. > Compared with {{LocalBufferPool}}, this is a non-rebalancing buffer pool > which will not participate in redistributing the left available buffers in > {{NetworkBufferPool}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029)