Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4488#discussion_r132818559
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/StreamTableSourceScan.scala
---
@@ -46,29 +47,29 @@ class StreamTableSourceScan(
val fieldNames = TableEnvironment.getFieldNames(tableSource).toList
val fieldTypes =
TableEnvironment.getFieldTypes(tableSource.getReturnType).toList
- val fieldCnt = fieldNames.length
+ val fields = fieldNames.zip(fieldTypes)
- val rowtime = tableSource match {
+ val withRowtime = tableSource match {
case timeSource: DefinedRowtimeAttribute if
timeSource.getRowtimeAttribute != null =>
--- End diff --
For the `DefinedRowtimeAttribute`, we hope the rowtime field can replace an
existing field. Just like register a DataStream, the rowtime field can be
appended but also can replace an existing field.
It is not related to this PR, but we can discuss it at here and to do it in
a separate issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
