[ 
https://issues.apache.org/jira/browse/FLINK-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577418#comment-14577418
 ] 

ASF GitHub Bot commented on FLINK-2093:
---------------------------------------

Github user andralungu commented on a diff in the pull request:

    https://github.com/apache/flink/pull/807#discussion_r31932002
  
    --- Diff: 
flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/operations/GraphOperationsITCase.java
 ---
    @@ -266,6 +266,47 @@ public void testUnion() throws Exception {
                                        "6,1,61\n";
        }
     
    +    @Test
    +    public void testDifference() throws Exception {
    +           /*
    +            * Test difference()
    +            */
    +        final ExecutionEnvironment env = 
ExecutionEnvironment.getExecutionEnvironment();
    +
    +        Graph<Long, Long, Long> graph = 
Graph.fromDataSet(TestGraphUtils.getLongLongVertexData(env),
    +                TestGraphUtils.getLongLongEdgeData(env), env);
    +
    +        List<Vertex<Long, Long>> vertices = new ArrayList<Vertex<Long, 
Long>>();
    +        List<Edge<Long, Long>> edges = new ArrayList<Edge<Long, Long>>();
    --- End diff --
    
    I would put these in TestGraphUtils, one remove is fine, but three can make 
the code  a bit difficult to read :)


> Add a difference method to Gelly's Graph class
> ----------------------------------------------
>
>                 Key: FLINK-2093
>                 URL: https://issues.apache.org/jira/browse/FLINK-2093
>             Project: Flink
>          Issue Type: New Feature
>          Components: Gelly
>    Affects Versions: 0.9
>            Reporter: Andra Lungu
>            Assignee: Shivani Ghatge
>            Priority: Minor
>
> This method will compute the difference between two graphs, returning a new 
> graph containing the vertices and edges that the current graph and the input 
> graph don't have in common. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to