Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/807#discussion_r31932002 --- Diff: flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/operations/GraphOperationsITCase.java --- @@ -266,6 +266,47 @@ public void testUnion() throws Exception { "6,1,61\n"; } + @Test + public void testDifference() throws Exception { + /* + * Test difference() + */ + final ExecutionEnvironment env = ExecutionEnvironment.getExecutionEnvironment(); + + Graph<Long, Long, Long> graph = Graph.fromDataSet(TestGraphUtils.getLongLongVertexData(env), + TestGraphUtils.getLongLongEdgeData(env), env); + + List<Vertex<Long, Long>> vertices = new ArrayList<Vertex<Long, Long>>(); + List<Edge<Long, Long>> edges = new ArrayList<Edge<Long, Long>>(); --- End diff -- I would put these in TestGraphUtils, one remove is fine, but three can make the code a bit difficult to read :)
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---