Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4537#discussion_r132932684
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -176,6 +177,10 @@ public FlinkKinesisConsumer(List<String> streams,
KinesisDeserializationSchema<T
// check the configuration properties for any conflicting
settings
KinesisConfigUtil.validateConsumerConfiguration(this.configProps);
+ checkArgument(
--- End diff --
How about first checking for null, and then for serializability? (Just seem
more intuitive to me)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
