Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4473#discussion_r133119309
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ProducerConfigConstants.java
---
@@ -20,14 +20,24 @@
import org.apache.flink.streaming.connectors.kinesis.FlinkKinesisProducer;
/**
+ * @deprecated
--- End diff --
@bowenli86 one thing to mention:
We should always try to have good Javadoc for why something is deprecated.
Sorry but I overlooked this on my reviewing. I'll address this myself this time
while merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
