Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4238#discussion_r133503488
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -148,7 +149,10 @@
/** Service to contend for and retrieve the leadership of JM and RM */
private final HighAvailabilityServices highAvailabilityServices;
- /** Blob cache manager used across jobs */
+ /** Blob server used across jobs */
+ private final BlobServer blobServer;
--- End diff --
I think the `JobMaster` should not depend on the `BlobServer` because the
`BlobServer` might run on a different node (along side to the dispatcher, for
example). Can we pass in the `BlobService` which can either be a `BlobServer`
or a `BlobCache`? I think we have to move the `register/releaseJob` methods to
the `BlobService` for that. Additionally, the `BlobServer` should simply do
nothing when these methods are called. That way, we can also pass in a
`BlobService` to the `Task` and the `TaskExecutor/TaskManager`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
