Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4238#discussion_r133685671
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java 
---
    @@ -148,7 +149,10 @@
        /** Service to contend for and retrieve the leadership of JM and RM */
        private final HighAvailabilityServices highAvailabilityServices;
     
    -   /** Blob cache manager used across jobs */
    +   /** Blob server used across jobs */
    +   private final BlobServer blobServer;
    --- End diff --
    
    Actually, I'd rather let the services involved in the life cycle of the 
BLOBs known what they are dealing with than adding empty `register/releaseJob` 
methods to the `BlobService`/`BlobServer`. Once we move the `BlobServer` out of 
the `JobMaster`, we can  change the class of the parameters and also remove the 
`register/releaseJob` calls.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to