[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

[kaibozhou]

Github user kaibozhou commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4355#discussion_r133925097
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
 ---
    @@ -405,6 +481,17 @@ class AggregationCodeGenerator(
           }
         }
     
    +    val aggFuncCode = Seq(
    +      genSetAggregationResults,
    +      genAccumulate,
    +      genRetract,
    +      genCreateAccumulators,
    +      genSetForwardedFields,
    +      genSetConstantFlags,
    +      genCreateOutputRow,
    +      genMergeAccumulatorsPair,
    +      genResetAccumulator).mkString("\n")
    --- End diff --
    
    It make sense，I have look at ProcessFunctionWithCleanupState，the 
cleanUp should be called whenever cleanupState is called.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---