Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4566#discussion_r133985865
  
    --- Diff: flink-dist/src/main/flink-bin/bin/config.sh ---
    @@ -351,8 +351,20 @@ if [ -z "$HADOOP_CONF_DIR" ]; then
         fi
     fi
     
    +# try and set HADOOP_CONF_DIR to some common default if it's not set
    +if [ -z "$HADOOP_CONF_DIR" ]; then
    +    if [ -d "/etc/hadoop/conf" ]; then
    +        HADOOP_CONF_DIR="/etc/hadoop/conf"
    +    fi
    +fi
    +
     
INTERNAL_HADOOP_CLASSPATHS="${HADOOP_CLASSPATH}:${HADOOP_CONF_DIR}:${YARN_CONF_DIR}"
     
    +# check if the "hadoop" binary is available, if yes, use that to augment 
the CLASSPATH
    +if command -v hadoop >/dev/null 2>&1; then
    +    
INTERNAL_HADOOP_CLASSPATHS="${HADOOP_CLASSPATH}:${HADOOP_CONF_DIR}:${YARN_CONF_DIR}:`hadoop
 classpath`"
    --- End diff --
    
    I would actually append `INTERNAL_HADOOP_CLASSPATHS` instead of overwriting 
it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to