[ 
https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136604#comment-16136604
 ] 

ASF GitHub Bot commented on FLINK-7206:
---------------------------------------

Github user kaibozhou commented on the issue:

    https://github.com/apache/flink/pull/4355
  
    In MapViewSerializer.scala, the function "override def serialize(record: 
MapView[K, V], target: DataOutputView):" need to access var map which defined 
in MapView.scala. Becase  mapSerializer.serialize(record.map, target) only 
accept java.util.Map, otherwise, we need to new java.util.Map to call this 
method, this is not very efficient.
    
    The problem is  ”private[flink] var map“ will be seen by Java users, In 
fact, we do not want users to see the implementation of MapView internal.
    
    Maybe use "protected" keyword in Java can solve the problem.
    



> Implementation of DataView to support state access for UDAGG
> ------------------------------------------------------------
>
>                 Key: FLINK-7206
>                 URL: https://issues.apache.org/jira/browse/FLINK-7206
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Kaibo Zhou
>            Assignee: Kaibo Zhou
>
> Implementation of MapView and ListView to support state access for UDAGG.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to