[ 
https://issues.apache.org/jira/browse/FLINK-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138090#comment-16138090
 ] 

ASF GitHub Bot commented on FLINK-6244:
---------------------------------------

Github user tedyu commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4320#discussion_r134692032
  
    --- Diff: 
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java
 ---
    @@ -348,7 +353,18 @@ private void updateNFA(NFA<IN> nfa) throws IOException 
{
         * @param event The current event to be processed
         * @param timestamp The timestamp of the event
         */
    -   protected abstract void processEvent(NFA<IN> nfa, IN event, long 
timestamp);
    +   private void processEvent(NFA<IN> nfa, IN event, long timestamp)  {
    +           Tuple2<Collection<Map<String, List<IN>>>, 
Collection<Tuple2<Map<String, List<IN>>, Long>>> patterns =
    +                   nfa.process(event, timestamp);
    +
    +           try {
    +                   processMatchedSequences(patterns.f0, timestamp);
    +                   processTimeoutedSequence(patterns.f1, timestamp);
    --- End diff --
    
    processTimeoutedSequence -> processTimedoutSequence


> Emit timeouted Patterns as Side Output
> --------------------------------------
>
>                 Key: FLINK-6244
>                 URL: https://issues.apache.org/jira/browse/FLINK-6244
>             Project: Flink
>          Issue Type: Improvement
>          Components: CEP
>    Affects Versions: 1.3.0
>            Reporter: Dawid Wysakowicz
>            Assignee: Dawid Wysakowicz
>             Fix For: 1.4.0
>
>
> Now that we have SideOuputs I think timeouted patterns should be emitted into 
> them rather than producing a stream of `Either`



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to