[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140810#comment-16140810 ]
ASF GitHub Bot commented on FLINK-7206: --------------------------------------- Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135138596 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -178,13 +294,15 @@ class AggregationCodeGenerator( | ${aggMapping(i)}, | (${accTypes(i)}) accs.getField($i));""".stripMargin } else { + val setDataView = genDataViewFieldSetter(s"acc$i", i) j""" | org.apache.flink.table.functions.AggregateFunction baseClass$i = | (org.apache.flink.table.functions.AggregateFunction) ${aggs(i)}; - | + | ${accTypes(i)} acc$i = (${accTypes(i)}) accs.getField($i); + | $setDataView --- End diff -- directly call `genDataViewFieldSetter(s"acc$i", i)` here? Would make it easier to follow the `acc$i` variables. > Implementation of DataView to support state access for UDAGG > ------------------------------------------------------------ > > Key: FLINK-7206 > URL: https://issues.apache.org/jira/browse/FLINK-7206 > Project: Flink > Issue Type: Sub-task > Components: Table API & SQL > Reporter: Kaibo Zhou > Assignee: Kaibo Zhou > > Implementation of MapView and ListView to support state access for UDAGG. -- This message was sent by Atlassian JIRA (v6.4.14#64029)