[
https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140792#comment-16140792
]
ASF GitHub Bot commented on FLINK-7206:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r135124134
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -759,10 +786,12 @@ object AggregateUtil {
: GroupCombineFunction[Row, Row] = {
val needRetract = false
- val (aggFieldIndexes, aggregates, accTypes) =
transformToAggregateFunctions(
+ val isStateBackedDataViews = false
+ val (aggFieldIndexes, aggregates, accTypes, accSpecs) =
transformToAggregateFunctions(
--- End diff --
`transformToAggregateFunctions` has a default value for
`isStateBackedDataViews`. So we don't need to pass a parameter. Moreover, we
only need to pass data view information to the code generator if the data views
are backed by state (if we make it an optional parameter). So most of the
changes here can be reverted (and also for all other operators that do not
support state backed views).
> Implementation of DataView to support state access for UDAGG
> ------------------------------------------------------------
>
> Key: FLINK-7206
> URL: https://issues.apache.org/jira/browse/FLINK-7206
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Kaibo Zhou
> Assignee: Kaibo Zhou
>
> Implementation of MapView and ListView to support state access for UDAGG.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
