[
https://issues.apache.org/jira/browse/FLINK-7516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141574#comment-16141574
]
ASF GitHub Bot commented on FLINK-7516:
---------------------------------------
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4593
[FLINK-7516][memory] do not allow copies into a read-only ByteBuffer
## What is the purpose of the change
`HybridMemorySegment#get(int, ByteBuffer, int)` allows writing into a
read-only `ByteBuffer` but this operation should be forbidden.
## Brief change log
- throw a `ReadOnlyBufferException` if trying to write into a read-only
`ByteBuffer`
## Verifying this change
This change added additional test methods to `MemorySegmentTestBase`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (yes)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (JavaDocs)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-7516
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4593.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4593
----
commit f2eb28d3cdbbe7ef4d2e66da263e47336b6f105d
Author: Nico Kruber <n...@data-artisans.com>
Date: 2017-08-22T16:33:55Z
[FLINK-7516][memory] do not allow copies into a read-only ByteBuffer
----
> HybridMemorySegment: do not allow copies into a read-only ByteBuffer
> --------------------------------------------------------------------
>
> Key: FLINK-7516
> URL: https://issues.apache.org/jira/browse/FLINK-7516
> Project: Flink
> Issue Type: Sub-task
> Components: Core, Network
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> {{HybridMemorySegment#get(int, ByteBuffer, int)}} allows writing into a
> read-only {{ByteBuffer}} but this operation should be forbidden.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
