Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4355#discussion_r135524948
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
 ---
    @@ -42,6 +46,18 @@ class AggregationCodeGenerator(
         input: TypeInformation[_ <: Any])
       extends CodeGenerator(config, nullableInput, input) {
     
    +  // set of statements for cleanup dataview that will be added only once
    +  // we use a LinkedHashSet to keep the insertion order
    +  private val reusableCleanupStatements = mutable.LinkedHashSet[String]()
    +
    +  /**
    +    * @return code block of statements that need to be placed in the 
cleanup() method of
    --- End diff --
    
    `RichFunction` does not have a `cleanup()` method. The `cleanup()` method 
is a method of `GeneratedAggregations`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to