[ 
https://issues.apache.org/jira/browse/FLINK-7558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16146935#comment-16146935
 ] 

ASF GitHub Bot commented on FLINK-7558:
---------------------------------------

Github user wuchong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4620#discussion_r136014662
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/validation/UserDefinedFunctionValidationTest.scala
 ---
    @@ -0,0 +1,42 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.table.api.validation
    +
    +import org.apache.flink.api.scala._
    +import org.apache.flink.table.api.ValidationException
    +import org.apache.flink.table.api.scala._
    +import org.apache.flink.table.expressions.utils.Func0
    +import org.apache.flink.table.utils.TableTestBase
    +import org.junit.Test
    +
    +class UserDefinedFunctionValidationTest extends TableTestBase {
    +
    +  @Test
    +  def testAppendSinkOnUpdatingTable(): Unit = {
    --- End diff --
    
    Could you change the test method name ? 


> Improve SQL ValidationException message.
> ----------------------------------------
>
>                 Key: FLINK-7558
>                 URL: https://issues.apache.org/jira/browse/FLINK-7558
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>
> org.apache.flink.table.api.ValidationException: SQL validation failed. 
> Operand types of could not be inferred. at 
> org.apache.flink.table.calcite.FlinkPlannerImpl.validate(FlinkPlannerImpl.scala:91)
>  at 
> org.apache.flink.table.api.TableEnvironment.sql(TableEnvironment.scala:513) 
> at 
> com.alibaba.blink.scala.tool.util.SqlJobAdapter.dealInserts(SqlJobAdapter.java:292)
>  at 
> com.alibaba.blink.scala.tool.util.JobBuildHelper.buildSqlJob(JobBuildHelper.java:80)
>  at com.alibaba.blink.scala.tool.JobLauncher.main(JobLauncher.java:138) 
> Caused by: org.apache.flink.table.api.ValidationException: Operand types of 
> could not be inferred. at 
> org.apache.flink.table.functions.utils.ScalarSqlFunction$$anon$2$$anonfun$2.apply(ScalarSqlFunction.scala:110)
>  at 
> org.apache.flink.table.functions.utils.ScalarSqlFunction$$anon$2$$anonfun$2.apply(ScalarSqlFunction.scala:110)
>  at scala.Option.getOrElse(Option.scala:121) at 
> org.apache.flink.table.functions.utils.ScalarSqlFunction$$anon$2.inferOperandTypes(ScalarSqlFunction.scala:110)
>  at 
> org.apache.calcite.sql.validate.SqlValidatorImpl.inferUnknownTypes(SqlValidatorImpl.java:1769)
>  at 
> ....



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to